We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

International Install Issues

    • 25663 MODX Staff
    • 12,272 Posts
    Ryan Thrash Reply #1, 20 years, 7 months ago
    Susan and David,

    Can you two consolidate all the bugs/tweaks/fixes into a single set of changes for finally laying to rest the issues we had with international installs and upgrades? There seems to be a smattering of things needed and you two are the most familiar. I can commit them to the trunk and make a test build to see if they’re in fact fixed. Thanks!

      Ryan Thrash, MODX Co-Founder
      Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
      • 6726
      • 7,075 Posts
      davidm Reply #2, 20 years, 7 months ago
      I am not sure I can do more than I have already done in the bug tracker. My understanding is there is only one thing to fix, and that is lines 95 and 96 of sqlParserClass (Given that the setup.sql file has been fixed and I suppose added to 0.9.1)

      Per Susan’s instruction, I had published a modified version for french people with the proper french language strings, as a temporary fix. The setup.sql fix + the sqlParserClass fix reported working well and solving install problems for those who previously had them.

      Now, the thing is to make this international, working with whatever config. Susan mentionned at the time she planned rewriting those using mysql_errno instead of language dependent strings.

      if (eregi('^duplicate key', mysql_error()) || (eregi('^alter', $sql_do) && eregi('^duplicate', mysql_error()))) continue;
if (eregi('^can\'t drop', mysql_error()) || (eregi('^alter', $sql_do) && eregi('^can\'t drop', mysql_error()))) continue;


      If I understand Susan correctly, the error message have to be replaced with errno (she pointed out this resource : http://www.mysqlfreaks.com/mysql_errors.php)

      But I wouldn’t know how to do that...

      I hope this clarifies the situation !
        .: COO - Commerce Guys - Community Driven Innovation :.

        MODx est l'outil id
        • 25663 MODX Staff
        • 12,272 Posts
        Ryan Thrash Reply #3, 20 years, 7 months ago
        That’s exactly what I’m talking about ... now hopefully Susan will look at it and make the errorno stuff happen for us and we can get it overwith and properly handled. smiley
          Ryan Thrash, MODX Co-Founder
          Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
          • 6726
          • 7,075 Posts
          davidm Reply #4, 20 years, 7 months ago
          OK then, should we send a PM to Susan to attract attention to this thread ?
            .: COO - Commerce Guys - Community Driven Innovation :.

            MODx est l'outil id
            • 28042 ☆ A M B ☆
            • 24,524 Posts
            sottwell Reply #5, 20 years, 7 months ago
            I see it.
              Studying MODX in the desert - http://sottwell.com
              Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
              Join the Slack Community - http://modx.org
              • 25663 MODX Staff
              • 12,272 Posts
              Ryan Thrash Reply #6, 20 years, 7 months ago
              Susan, can you give me confirmation that David’s summary is in fact what is all that’s needed. Last time we released I thought we had it nailed, and you know what happened there. wink
                Ryan Thrash, MODX Co-Founder
                Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                • 28042 ☆ A M B ☆
                • 24,524 Posts
                sottwell Reply #7, 20 years, 7 months ago
                I think so, I thought I already did it and passed the modified file on. I don’t seem to have it anywhere here on my local machine. I’ll have to do it again; I don’t really remember now exactly what I did.
                  Studying MODX in the desert - http://sottwell.com
                  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
                  Join the Slack Community - http://modx.org
                  • 25663 MODX Staff
                  • 12,272 Posts
                  Ryan Thrash Reply #8, 20 years, 7 months ago
                  Is it in the known issues thread, and does it use errorno?
                    Ryan Thrash, MODX Co-Founder
                    Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                    • 28042 ☆ A M B ☆
                    • 24,524 Posts
                    sottwell Reply #9, 20 years, 7 months ago
                    Something like this, I believe...

                    // Ignore duplicate and drop errors - Raymond 
if ($this->ignoreDuplicateErrors){
    if((eregi('^alter', $sql_do) && mysql_errorno() == 1022) continue; // duplicate key error
    if((eregi('^alter', $sql_do) && mysql_errorno() == 1091) continue; // can't drop table error

    //if (eregi('^duplicate key', mysql_error()) || (eregi('^alter', $sql_do) && eregi('^duplicate', mysql_error()))) continue;
    //if (eregi('^can\'t drop', mysql_error()) || (eregi('^alter', $sql_do) && eregi('^can\'t drop', mysql_error()))) continue;
}
// End Ignore duplicate
                      Studying MODX in the desert - http://sottwell.com
                      Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
                      Join the Slack Community - http://modx.org