File Manager Failuer

- MODX Staff
- 12,272 Posts
Ryan Thrash Reply #1, 20 years, 9 months ago
The logic that checks whether or not a file can be uploaded protesetd on me today on a very oddly configured 4.3.3 server:
```
if (((@ini_set("file_uploads", 1) === true) || get_cfg_var("file_uploads") == 1) && is_writable($startpath)) {
```
The switch that works as expected:
```
if (((@ini_get("file_uploads") == true) || get_cfg_var("file_uploads") == 1) && is_writable($startpath)) {
```
Discussed also here: http://www.etomite.org/forums/lofiversion/index.php/t1995.html

I’m checking this in, but we really need to test it. It works fine on the really old PHP4.3.3 config and my other PHP5 server. So I’m hoping it causes no other issues.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me