Various installation patches, fixes, etc.

I’d like to make sure we address all the various installation issues as thoroughly as possible before releasing 0.9.1.

@Susan & David - as a lot of these temporary fixes and patches have come from you guys, can one of you detail the various patches that have been applied along with any patch files associated with each? Here are the major issues I’m aware of and how I see the permanent solution being implemented (if applicable):

* Manager include path issues
I believe this issue was resolved by adding full include paths from the /manager/ root directory to all places in the manager code. I think we should permanently address this by using $modx->getManagerPath() where appropriate in the include statements. Thoughts?

* setup.sql
I know there are a lot of versions of this out there. Do we have a solid summary of all the issues that were addressed here? If not, I’ll assume the latest setup.sql in SVN is ready to go.

* /install/installprocessor.php
I have addressed several issues here, the most important being some changes to the way the dbname is handled, replacing the mysql_create_db() function with a "CREATE DATABASE $dbname" SQL query to support MySQL 4.x installations.

* /install/sqlParser.class.php
I changed the mysql_select_db function here to remove the str_replace that was removing the tick-marks from the dbname, because this was already done when calling the function from installprocessor.php.

* returning MySQL Error numbers instead of messages
Susan, if you get this done, please let me know so I can include this fix as well.

Cheers...

I’m currently experiencing DB connection failures on a client’s 3.23.49 MySQL and PHP 4.3.3 with rev 538.

It was the jack leg config they’ve got. Localhost failed. 127.0.0.1 works.

Jason, Susan did all the work on those patches, I can’t answer that.

The path issue has only come up (to my knowledge) with a free hosting offered by a french DSL provider named "Free".

About setup.sql, the latest I have is from Flyspray (http://modxcms.com/bugs/task/81). The install problems seem to have come from sqlParserclass, not from setup.sql it would seem. But then again I am not sure about that, it’s not really my area...