New Captcha Package

I have a version of the core with all captcha references removed. It involves changes to four files, one file deletion and one directory deletion.

I also have a theoretical captcha package that can be added, but haven’t been able to build the transport file (See: http://modxcms.com/forums/index.php/topic,28161.0.html).

It works fine when installed manually, though.

Once the build problem is solved, I can test it and we can get on with Jason’s dream of removing captcha from the core.

Any chance you would create a patch of the changes and upload into a new team code review in Crucible?

Also, re: the Package Builder, I assume you mean the manager interface, and not the scripted API version?

Quote from: OpenGeek at Aug 17, 2008, 01:09 PM

Any chance you would create a patch of the changes and upload into a new team code review in Crucible?

Also, re: the Package Builder, I assume you mean the manager interface, and not the scripted API version?

I’ll be glad to create a patch, but first I should create the package that replaces it and test that to make sure I haven’t missed anything.

re: the Package Builder, I meant both. As I said here http://modxcms.com/forums/index.php/topic,28161.0.html)," target="_blank" rel="nofollow">(See: http://modxcms.com/forums/index.php/topic,28161.0.html),

, when I run the same *script* I used before to create the EzFAQ package it builds a giant package that contains all the system settings and lexicon entries before it runs out of memory. The same thing happens in the manager no matter what I put in the package.

Quote from: BobRay at Aug 17, 2008, 01:42 PM

when I run the same *script* I used before to create the EzFAQ package it builds a giant package that contains all the system settings and lexicon entries before it runs out of memory. The same thing happens in the manager no matter what I put in the package.

Did you select the core namespace? If so, it’s probably autopackaging all the settings/lexicon strings for that namespace (like it’s designed to).

This is a debate; I think I might create an exception for ’core’ namespace packages, where they dont autopackage. Thoughts?

Quote from: splittingred at Aug 17, 2008, 07:26 PM

This is a debate; I think I might create an exception for ’core’ namespace packages, where they dont autopackage. Thoughts?

IMO the core namespace should not be available in the package builder interface at this time, but needs to be in the API.

I put the Patch up: CR-MODX-33.  It’s based on the diff from 3946.

Note that the manager/assets/captcha directory is removed completely, I’m not sure that’s evident in Crucible.

There’s only one loose end that I’m aware of. This line is in all the default lexicon files:



It’s duplicated in my new captcha lexicon file captcha.inc.php. I wasn’t sure if I should go ahead and pull it from all those different lexicon files.

Can you go ahead and move your review out of Draft status so we can work with it?

Quote from: OpenGeek at Aug 18, 2008, 07:54 PM

Can you go ahead and move your review out of Draft status so we can work with it?

Done.