We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 32963
    • 1,732 Posts
    I would like to suggest that we use new tables when merging snippet/chunk/etc and users:

    example

    {prefix}_widgets
    {prefix}_users
    {prefix}_user_attributes
    {prefix}_user_roles

    PROs:
    This way we will not break existing system that rely on the old tables. We should provide the user with an option to remove old data tables if they are present. This approach will also give the user enough time to gradually update their apps to use the new tables.

    CONs:
    Duplicate data will exist within the database until old tables are removed.

      xWisdom
      www.xwisdomhtml.com
      The fear of the Lord is the beginning of wisdom:
      MODx Co-Founder - Create and do more with less.
      • 22303 MODX Staff
      • 10,725 Posts
      Agreed, and I’d really like the chance to review any structures we come up with for this, so we can optimize the structures appropriately. Currently, I see a wealth of issues in our db structures that could be improved (using proper column types, indexes, and more).
        • 1764
        • 680 Posts
        Quote from: OpenGeek at Nov 18, 2005, 12:09 PM

        Currently, I see a wealth of issues in our db structures that could be improved (using proper column types, indexes, and more).

        Yes definitely. At some point we’ll have to take a close look at this. There are a lot of structural improvements that could be made in the database.
          • 25663 MODX Staff
          • 12,272 Posts
          I am all for a smooth transition and think extra tables is a great safety measure too!
            Ryan Thrash, MODX Co-Founder
            Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
            • 22303 MODX Staff
            • 10,725 Posts
            Alright, that said, who is doing what? I’d like to suggest we track these refactorings as feature requests in Flyspray. That way we know at least relatively who’s doing what to which code. As of now, I plan on doing the majority of the user merge work, so I’ll add a task for this to Flyspray and assign myself to it.

            Also, I want to do this merging with an eye towards database abstraction. Try and refactor as much code as you can to use the DBAPI methods for queries, so we can identify weaknesses and needed additions to that API, as well as adding postgreSQL support as a first case as soon as possible following these merges.
              • 22303 MODX Staff
              • 10,725 Posts
              Actually, I’m going to add Merge Web and Manager Users as a To Do task in Flyspray, to separate it from feature requests (since we internally decided to do this).
                • 1764
                • 680 Posts
                I would like to handle the merging of the widgets. I’m going to see if I can make some progress in that direction tomorrow. If I get too tied up with other things then someone else may have to take over though.
                  • 25663 MODX Staff
                  • 12,272 Posts
                  How’s the widget merging going Adam?
                    Ryan Thrash, MODX Co-Founder
                    Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                    • 1764
                    • 680 Posts
                    Quote from: rthrash at Dec 07, 2005, 01:08 AM

                    How’s the widget merging going Adam?

                    I have some work done but havn’t had time to work on it recently. I actually just talked to Jason last night and he said to hold off on it since he’s working on some pretty big changes to the API and DB that might affect the way we deal with widgets.

                    I might still take some time to work on some code that could easily be plugged into whatever we end up with.