We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 4018
    • 1,131 Posts
    Ryan,

    Just noticed something in your trunk on the SVN server. In /manager/includes/document.parser.class.inc.php, around line 167, it looks like you changed it from this:

    	function getSettings() {
    		global $base_url, $base_path, $site_url;
    		if(file_exists($base_path.'/assets/cache/siteCache.idx.php')) {
    			include_once $base_path.'/assets/cache/siteCache.idx.php';
    		} else {
    			$result = $this->dbQuery('SELECT setting_name, setting_value FROM '.$this->getFullTableName('system_settings'));
    			while ($row = $this->fetchRow($result, 'both')) {
    				$this->config[$row[0]] = $row[1];
    			}
    		}
    
    		// store base_url and base_path inside config array
    		$this->config['base_url'] = $base_url;
    		$this->config['base_path'] = $base_path;
    		$this->config['site_url'] = $site_url;
    


    To this:

    	function getSettings() {
    		global $base_url, $base_path;
    		if(file_exists($base_path.'/assets/cache/siteCache.idx.php')) {
    			include_once $base_path.'/assets/cache/siteCache.idx.php';
    		} else {
    			$result = $this->dbQuery('SELECT setting_name, setting_value FROM '.$this->getFullTableName('system_settings'));
    			while ($row = $this->fetchRow($result, 'both')) {
    				$this->config[$row[0]] = $row[1];
    			}
    		}
    
    		// store base_url and base_path inside config array
    		$this->config['base_url'] = $base_url;
    		$this->config['base_path'] = $base_path;
    


    Err..is this correct? Looks like the $site_url variable was removed. Don’t we need it for the resource browser, plugins, and what not? Just an observation. wink

    Also, which trunk should we use for testing? The main one or yours? Still a little wet behind the ears with using SVN! Heh heh!
      Jeff Whitfield

      "I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."
      • 25663 MODX Staff
      • 12,272 Posts
      I wouldn’t pay much attention to my trunk at all honestly. It is currently in a very, very, very early pre TP4 manager state. The trunk however is something to pay attention to. wink
        Ryan Thrash, MODX Co-Founder
        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
        • 4018
        • 1,131 Posts
        Quote from: rthrash at Aug 19, 2005, 01:24 AM

        I wouldn’t pay much attention to my trunk at all honestly. It is currently in a very, very, very early pre TP4 manager state. The trunk however is something to pay attention to. wink

        Yeah, I figured that. It’s just that I was sent (or downloaded) a zip file with some updates to TP3.1....I think it was Ryan that did this, not sure. Anyways...his trunk reflects the same changes, which is why I asked. And the change above was one of them. Just needed to make sure that this is correct and will be something in the trunk. If it is, umm...not sure if it makes sense to leave out that variable, it might break some code for some plugins and whatnot.
          Jeff Whitfield

          "I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."