TP3: Getting it Out

MODX Staff
12,272 Posts

Ryan Thrash Reply #1, 21 years, 2 months ago

Here’s the list of things that I think should be done prior to releasing TP3 on the world:

~~Fix the @DOCUMENT binding bug (http://vertexworks.com/forums/index.php?topic=480.msg2908#msg2908)~~
Get Zi’s design in as the new default template (http://zidesigns.com/html/)
~~Fix Zi’s layout 3 in the manager for a top-menu implentation and make it the default just for grins~~
Get a non-etomite looking color scheme for the manager
Release TinyMCE as a plug-in (can’t seem to find it here... thought it was, though.. hmmm)
~~Can’t add Custom DocTypes in FireFox~~
~~Perpetual loop when previewing a document set for disposition as an attachment~~

Let me know and I’ll add more to the list, and cross them out as they’re done. Other critical areas to address, folks?

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

MODX Staff
12,272 Posts

Ryan Thrash Reply #2, 21 years, 2 months ago

OK... seems that the critical bugs have been fixed. I move that we release tomorrow... and add the graphical stuff for TP4 when we really start marketing the project.

Please grab the latest Trunk and beat it up really well. Thanks!

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

MODX Staff
10,725 Posts

opengeek Reply #3, 21 years, 2 months ago

I’m having problem with Alias’ being trimmed of dashes now -- I use dashes in most of my aliases and no matter what I do, it reverts them to the aliases without my dash? I think that needs to be fixed for sure, before we release

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

MODX Staff
12,272 Posts

Ryan Thrash Reply #4, 21 years, 2 months ago

it’s trimming them of periods, too. This is a fatal flaw.... Time to get it fixed... now where?

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

MODX Staff
10,725 Posts

opengeek Reply #5, 21 years, 2 months ago

yeah, I made some adjustments to this function to solve these issues:

first, it was replacing spaces with _, which is not search-engine friendly; every SEO expert I’ve ever talked with recommends using dashes (-) rather that underscores to represent spaces; so now spaces will get replaced with a dash (-)

second (and what is really causing the problem), it was using the regexp /\W/ to identify all "special characters" and simply remove them; I do not believe this is correct so I am changing this to more closely match the behavior of WordPress in this area (updates when I get it done)

finally, all of this is happening regardless of the automatic alias setting; shouldn’t we only be doing the extended alias cleanup and such if that option is checked? the only behavior limited to the automatic alias setting is when an alias is empty, in which case an alias is generated from the page-title based on these rules. if we get the rules down for stripping the alias, then I’m not opposed to this cleanup going on for every page, but I just want to see what others think...

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

3,975 Posts

Zaigham (aka zi) Reply #6, 21 years, 2 months ago

OK guys !

Here’s my fix to Menu !

Download the "l3mnu.php.txt" and "1.php.txt", rename extension to .php, place it under manager/frames,

l3navbar.css.txt , rename extension to ".css", place it under manager/styles folder,

Changelog:

l3mnu.php -> Menus added, permission system parameters updated.

1.php -> Frame’s height adjusted.

CSS file -> its added to separate the Layout 3 menu, bcz i think it’s better ! (Final is upto you)

Thanks !

Regards,

zi

Zaigham R - MODX Professional | Skype | Email | Twitter

Digging the interwebs for #MODX gems and bringing it to you. modx.link

MODX Staff
10,725 Posts

opengeek Reply #7, 21 years, 2 months ago

Quote from: OpenGeek at Jul 16, 2005, 01:44 PM

first, it was replacing spaces with _, which is not search-engine friendly; every SEO expert I’ve ever talked with recommends using dashes (-) rather that underscores to represent spaces; so now spaces will get replaced with a dash (-)

second (and what is really causing the problem), it was using the regexp /\W/ to identify all "special characters" and simply remove them; I do not believe this is correct so I am changing this to more closely match the behavior of WordPress in this area (updates when I get it done)

Ok, this is now adjusted to remove spaces or other non-alphanumeric characters, replace multiple dashes (--) or spaces with a dash, with the exception of the following characters -> ( _ . - ). Here is the updated code for the stripAlias($alias) function:

function stripAlias($alias) {
	$alias = strip_tags($alias);
	$alias = strtolower($alias);
	$alias = preg_replace('/&.+?;/', '', $alias); // kill entities
	$alias = preg_replace('/[^\.%a-z0-9 _-]/', '', $alias);
	$alias = preg_replace('/\s+/', '-', $alias);
	$alias = preg_replace('|-+|', '-', $alias);
	$alias = trim($alias, '-');
	return $alias;
}

This can still use refinement to handle UTF-8 and multi-byte characters, but this should be sufficient for TP3 release.

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

MODX Staff
12,272 Posts

Ryan Thrash Reply #8, 21 years, 2 months ago

Here’s the most up to date repository (rev 168) for your testing pleasure. It would seem that there are some session related issues as pointed out by Strider. These should probably be addressed prior to release. There are also some Safari issues with Zi’s layout (3rd one). I’ll test that ASAP and see what I can work out.

Otherwise, please test away.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me