We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 32963
    • 1,732 Posts
    Quote from: rthrash at Jun 21, 2005, 08:23 AM

    Yeah... I think that Richtext should not even be an option UNLESS a RTE is installed. A little error checking I guess.

    Ok, I’ll add that feature to the RichText widget but that’s after TP3
      xWisdom
      www.xwisdomhtml.com
      The fear of the Lord is the beginning of wisdom:
      MODx Co-Founder - Create and do more with less.
      • 25663 MODX Staff
      • 12,272 Posts
      Sounds like a plan!
        Ryan Thrash, MODX Co-Founder
        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
        • 6661
        • 119 Posts
        Quote from: xwisdom at Jun 20, 2005, 06:27 PM

        Well that’s two down for RichText editors as plugins (Ryan and Jason). I’m for (FCK integrated)
        What anyone else?

        It’s probably too late on this but I’m for FCK integrated. To really get the most out of something like this it’s best to have it part of the core. One of the things I hate about other systems like TYPO3 is that everything is a module, especially things that should be considered essential. Also, things such as file/image browser, link browser, etc should be part of the FCK integration
          • 25663 MODX Staff
          • 12,272 Posts
          I totally agree that one should ship, but it also should be removable if needed. That way if we decide to get lazy, the users can update it more easily themselves. And I think FCK should probably be the one to ship by default due to its future implications in MODx. smiley
            Ryan Thrash, MODX Co-Founder
            Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
            • 34162
            • 1 Posts
            FWIW, and being late to the party, I’d also have voted integrated. Long term I think we’d be better served having one, fully supported and fully integrated editor than the choice of several that breaks other things/aren’t able to be supported.

            But I’m mostly just chiming in to prove that I’m still reading things and to have something to point to later, so feel free to ignore me. tongue
              • 22303 MODX Staff
              • 10,725 Posts
              I’d just like to point out that making all of the editors pluggable via well-defined points makes it easier for all the various editor preferences we have to be realized, and does nothing to prevent the tightest integration with any particular one that might provide special features to the core. In addition, the editors themselves are progressing to a point where most all of their integration points can be maintained separately from the core install. So, providing this feature for anyone to integrate any editor for use in the manager while essentially changing none of the functionality is a win-win situation in my view.
                • 32963
                • 1,732 Posts
                Wow! 3 Votes for plugin editors and 3 Votes for at least on integrated editor smiley

                Ok, let’s play with the all editors plugin option for a time. We can ship TP3 with FCKeditor plugin as the default while TinyMCE will be made available from the download page.

                If things get sticky we can always switch back to integrated mode smiley
                  xWisdom
                  www.xwisdomhtml.com
                  The fear of the Lord is the beginning of wisdom:
                  MODx Co-Founder - Create and do more with less.
                  • 28042 ☆ A M B ☆
                  • 24,524 Posts
                  Not really a huge issue but these editors don’t work on Safari, and probably won’t for a good while. Safari still doesn’t support some of the major javascript functionality. From the forums on some of them, I see that their authors are in contact with Apple development to try to get that remedied.
                    Studying MODX in the desert - http://sottwell.com
                    Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
                    Join the Slack Community - http://modx.org
                    • 32963
                    • 1,732 Posts
                    Hi,

                    Both editors are plug-able.? smiley? Please see the attached screen shot:



                    While working on these two plugins I found a bug inside the system confiuration screen. It has to do with eascaping and saving single quotes (’). The mysql_escape_string and addslashes did not do a great job at all so I when ahead and created my own escapeDoubleQuotes() function which works like a charm.

                    One good side effect to this is that I was also able to eliminate the base64_encode functions used on plugins. From my test I was able to reduce the size of the plugin cache from 42KB to around 34KB. This also means that the system no longer have to decode the plugins before executing them. The removal of the base64_decode functions will offer some improvement in speed.



                      xWisdom
                      www.xwisdomhtml.com
                      The fear of the Lord is the beginning of wisdom:
                      MODx Co-Founder - Create and do more with less.
                      • 32963
                      • 1,732 Posts
                      I’ve just removed all the base64 functions from snippets, plugins and chunks cache and I was able to reduce the cache file by about 37KB.

                      I guess we could further reduce the size of the cache file by another 30-40% by applying some php compression/obfuscation to remove comments and whitespaces. Does anyone know of such functions or libraries?
                        xWisdom
                        www.xwisdomhtml.com
                        The fear of the Lord is the beginning of wisdom:
                        MODx Co-Founder - Create and do more with less.