[[# comments go here]] would be neat. did you write a feature request for that yet?
-
☆ A M B ☆
- 3,141 Posts
Did you try using it?
It will attempt to find a snippet named "# comments go here" - can’t find it & eat the tag.
The [[# This is a comment]] notation seems to be working because unknown snippets don’t produce any output, but I think it still would be a good idea to officially add the # as a tag type so the # is reserved for comment purposes and not used as a new tag type in the future.
Has anybody logged this as a feature request yet?
-
☆ A M B ☆
- 3,141 Posts
Not that I know off, but you could do a search on "comment".
-
☆ A M B ☆
- 3,141 Posts
It’s good that it’s filed now, but I’m not convinced yet.
It works - so why add extra code to make it "official"?
I also can’t imagine any new tag types being added in the future...
It works yes, and no action is necessary other than to reserve the # for that purpose and put it in the documentation.
But the # should be reserved otherwise its an unofficial hack which may break in the future if the # is used for another purpose.
Additionally, if it’s an official feataure it can be added to the docs, and newbies won’t have to figure it out for themselves.
Jason
-
☆ A M B ☆
- 3,141 Posts
IMO (tho I can be wrong) it doesn’t have to be an official feature to be there.
Tada!
http://rtfm.modx.com/display/revolution20/Tag+Syntax#TagSyntax-Commenttags