on PHP 7.3 FastCGI produces a warning in modcachemanager.class.php on line 580

12 Posts

zhzhzh Reply #1, 5 years, 9 months ago

I upgraded my PHP version from 7.0.x to 7.3.0 (MODx is running 2.6.5-pl).

Now FastCGI/apache is producing the following warning:

[Tue Jan 08 ....] [fcgid:warn] [pid .....] [client xxx.xxx.xxx.xxx:....] mod_fcgid: stderr: PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /home/..../htdocs/core/model/modx/modcachemanager.class.php on line 580, referer: ....

Should I be concerned?

1 Posts

phcrew Reply #2, 5 years, 7 months ago

hi zhzhzh,
just empty cache in modx manager and error message disappears.

greetings

24,544 Posts

BobRay Reply #3, 5 years, 7 months ago

No, it's really just a suggestion about coding style. If there were a real issue, it would be an error rather than a warning.

If you look at that line in the modCacheManager file (assuming that it still says "continue 2" -- mine doesn't) the odds are very good that you can safely replace continue 2 with this:

break;

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

☆ A M B ☆
3,141 Posts

Mark Hamstra Reply #4, 5 years, 7 months ago

This should've been fixed in 2.7.1. If it's not, please open an issue on github.

Mark Hamstra • Developer spending his days working on Premium Extras and a MODX Site Dashboard with the ability to remotely upgrade MODX and extras to make the MODX world a little better.

Tweet me @mark_hamstra, check my infrequent blog at markhamstra.com, my slightly more frequent ramblings at MODX.today or see code at Github.