Url Problem Thread Pagination Discuss - My Forums

Url Problem Thread Pagination Discuss

onx1764 — Apr 08, 2016, 03:37 PM

Hello,

it would be great if anyone here can help out with a really weird problem concerning discuss; The 'url' placeholder in the thread paginations generates a url with the correct page query but the url itself is the same like in the board pagination, have tried many things so far but no idea whats going on. It's a migration from an smf board wrapped in a theme with minifyfx as compressor for js and css, everything is in place and working but eventually this plays a role regarding the url problem. If needed i can send further infos per pm.

Re: Url Problem Thread Pagination Discuss

nuan88 — Apr 18, 2016, 10:26 AM

Ok great you found a solution. No, unfortunately no further development is happening on Discuss.

There is a Discuss2 written as I understand by The Dunnock a couple years ago, but due to the LLC's resources being maxed out, the alpha version was released to the community. Since then, no progress so far, although I am hopeful.

https://forums.modx.com/thread/96666/discuss-2-releasing-a-new-native-forum-solution-for-revo

Re: Url Problem Thread Pagination Discuss (Best Answer)

onx1764 — Apr 18, 2016, 05:57 AM

Quote from: nuan88 at Apr 12, 2016, 03:51 AM

My suggestion is that you may need to make a custom snippet here, otherwise i don't know how we can force makeURL do the right thing.

Well, omitted that Discuss runs at version 1.2.2(dev). Problem is fixed by using the build.php snippet from version 1.2-pl which can be found here: /core/components/discuss/hooks/pagination/build.php. If anyone uses the version too and something goes wrong it might be a good guess to compare code with older versions. Could be done directly on github: https://github.com/modxcms/Discuss/tree/develop

Anyone here knows wether the devs are still working on Discuss / pull request / bug report make sense in this case?

Re: Url Problem Thread Pagination Discuss

nuan88 — Apr 12, 2016, 07:46 AM

One last point, it might not be important. Discuss uses some system to build a page by getting one tpl after another. I personally was never able to find where this was decided, there must be code saying go get tpl_34 then tpl_58...

It almost seems like you are grabbing the wrong tpl on this page, otherwise how are we getting a board url rather than a thread url...

Just trying to think about the problem from every angle.

Re: Url Problem Thread Pagination Discuss

nuan88 — Apr 11, 2016, 10:51 PM

Ok here is my thinking, you are much more of a developer than I am so pls take it with a grain of salt. One thing I want to point out is that the tpl I found might not be the right one, there is a lot of tpls there. I think you definitely need to find the right tpl.

If you have made any changes to the tpl previously, then that could be the problem, but it seems that you haven't, although I am wondering about the "no-login-fields-visible" in the url.

My suggestion is that you may need to make a custom snippet here, otherwise i don't know how we can force makeURL do the right thing. I can't see how it could be caching when its making a URL for a board rather than a thread. Unless the tpl has been modified, then that might fix the problem.

What seems to strange to me is that this part of the code (again, assuming this tpl is the right one or looks like the right one):

Must not exist, as it would be [[+threads]] at the board level.

Re: Url Problem Thread Pagination Discuss

onx1764 — Apr 11, 2016, 05:16 PM

Quote from: nuan88 at Apr 09, 2016, 08:17 AM

(assuming i have the right pagination). What is your's coming up as?

Problem occurs within the thread related pagination on the right side of thread-titles if more pages exist.

Quote from: nuan88 at Apr 09, 2016, 08:17 AM

I found this in one tpl, but only trial and error can tell us if this is the right one:

core/components/discuss/themes/default/pages/thread/index.tpl

/core/components/discuss/themes/default/chunks/pagination/thread/paginationlink.chunk.tpl

[[+text]]

'url' should generate this: https://forums.modx.com/thread/99762/no-login-fields-visible?page=1">1
but generate that: https://forums.modx.com/board=27?page=1">1

Exchanged 'url' with other thread placeholders and get always the right values in the data-link for every single thread, even the page querys are correct but not the url. To me it looks like a placeholder/geturl/makeurl problem but could also be a caching problem inside Discuss.

Re: Url Problem Thread Pagination Discuss

nuan88 — Apr 09, 2016, 03:17 AM

I try to support Discuss, let me try to help. You can find the right tpl and change it, but it might be a bit tricky. We also might need to figure out how Discuss makes that pagination.

Here is a pic, is this the pagination with the problem? In a subforum?

In my forum, the url is coming up as forums/board/65/?page=3 (assuming i have the right pagination). What is your's coming up as?

I found this in one tpl, but only trial and error can tell us if this is the right one:

core/components/discuss/themes/default/pages/thread/index.tpl

    	
            [[+posts]]
        
        [[+pagination:notempty=`
        [[+pagination]]
`]]