www.domain.com/DOCID - My Forums

Re: www.domain.com/DOCID

danilocuculic — Mar 20, 2014, 05:57 AM

Quote from: juliolopez78 at Mar 19, 2014, 05:23 PM

QuickManager issue aside, are you saying that in 1.0.14 or whatever is next, www.domain.tld/45 won't work? or will you add an option to the MODX config settings to allow this kind of url?
An option to turn it on or off would be great. I somehow doubt that I'm the only one out there that uses that format of url with MODx.

You're not! And this is quick fix (maybe not the sanest one, after Vagrant+CentOS docs and stepping through get/cleanDocumentIdentifier() functions gave me a terrible headache):

Change //@TODO in this line:
https://github.com/modxcms/evolution/blob/develop/manager/includes/document.parser.class.inc.php#L1577

with the following code:

					          if (is_numeric($alias) && !empty($this->aliasListing[intval($alias)])) {
                      $this->documentIdentifier = intval($alias);
                    } else {

wrapping $this->sendErrorPage(); in closing else afterwards:

                    $this->sendErrorPage();
                }

Re: www.domain.com/DOCID

danilocuculic — Mar 20, 2014, 05:46 AM

Quote from: Jako at Mar 19, 2014, 11:13 AM

The QuickManager issue will not be better with or without that. That should be a url generating thing inside of QuickManager.

Understood, so is it advisable to open QM+ issue on Github - because that's how QM+ formats redirects on resource insertion from frontend toolbar?

Re: www.domain.com/DOCID

juliolopez78 — Mar 19, 2014, 01:26 PM

Thanks!

Re: www.domain.com/DOCID

Jako — Mar 19, 2014, 12:57 PM

An option to turn it on or off would be great.

Will be done that way.

Re: www.domain.com/DOCID

juliolopez78 — Mar 19, 2014, 12:23 PM

QuickManager issue aside, are you saying that in 1.0.14 or whatever is next, www.domain.tld/45 won't work? or will you add an option to the MODX config settings to allow this kind of url?

An option to turn it on or off would be great. I somehow doubt that I'm the only one out there that uses that format of url with MODx.

Re: www.domain.com/DOCID

Jako — Mar 19, 2014, 06:13 AM

The 1.0.13 code of cleanDocumentIdentifier allows id based document identifiers in alias path mode only if the alias path to the parent is set right in my opinion. I think this is a good option to hide documents from direct access, so my commit should be better reverted or only be active in a sort of debug mode.

The QuickManager issue will not be better with or without that. That should be a url generating thing inside of QuickManager.

Re: www.domain.com/DOCID

danilocuculic — Mar 19, 2014, 02:35 AM

Quote from: Jako at Mar 18, 2014, 10:08 PM

It just allows the use of an id as alias (in that case $this->documentListing[$this->documentIdentifier] is not found) that is somehow not treated right by cleanDocumentIdentifier. Does it work if you remove the else branch? But the documentMethode is changed to 'id' afterwards and documentIdentifier should be an intval then.

Ok, I'm preparing Vagrant MODX setup to start debugging this locally. In the meantime - does opening address

works for anyone upgraded to 1.0.13 ? Just trying to eliminate my environment specifics (like subdomain, renamed manager folder etc.)

Re: www.domain.com/DOCID

Jako — Mar 18, 2014, 05:08 PM

Don't think that this commit breaks QuickManager, but I did not have checked that.

It just allows the use of an id as alias (in that case $this->documentListing[$this->documentIdentifier] is not found) that is somehow not treated right by cleanDocumentIdentifier. Does it work if you remove the else branch? But the documentMethode is changed to 'id' afterwards and documentIdentifier should be an intval then.

Re: www.domain.com/DOCID

danilocuculic — Mar 18, 2014, 12:05 PM

Testing this with public release of Evolution 1.0.13 - it still returns 404 when inserting document from QuickManager+:

GET http:///48?quickmanagerclose=1 404 (Not Found)  index.php?a=4&pid=2&quickmanager=1:1

MODX configuration

XHTML URLs: Yes
Use FriendlyURLs: Yes
Use SEO Strict URLs: No

Anyone reviewed final 1.0.13 release after linked commit?
https://github.com/modxcms/evolution/commit/63856c833e1ba9d02cac1f6fa68bac20144f0b25

Re: www.domain.com/DOCID

juliolopez78 — Feb 12, 2014, 07:53 AM

Hello,

I've encountered this same problem and was able to fix it by replacing the released document parser with the one over at GitHub. Thanks for the help Jako. I just have one question, since I'm now working with a version of the parser that is "in development" but the rest of my MODX install is still the 1.0.12 release, will it be any less stable?