Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled) - My Forums

Re: Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

sheeley — Jul 25, 2007, 08:10 PM

I’ve been playing more with PPP, and have found one easier fix to PPP not working with users who are not logged in. In propagate (around line 470, not sure if my numbers are correct), I added to the initial check:

/* Safety check to ensure user is the logged in user if not an allowed editor */
			if (($ppp_userId != $modx->getLoginUserID()) && ($ppp_editOtherUser != 1)) {
				echo "Something went wrong. Sorry.";
				return false;
			}

^ Original. All well and good if they are already logged in, but if not:

elseif ("" == $modx->getLoginUserID()){
				return true;
			}

I thought there may have been a better spot to check earlier in the code, but perhaps not. I’m not sure how often PPP gets called on pages people aren’t logged in on, but for me, there are a few forms which will be used by both those logged in and out, and it’ll be nice for them to not have to enter info.

Re: Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

Soshite — Jul 15, 2007, 09:28 PM

EDIT: How weird...the issue is gone now.

Re: Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

Soshite — Jul 15, 2007, 08:54 PM

Nothing code-breaking, but the snippet.efreg.txt file didn’t update the version number to 0.2 Beta.

Nothing a few keys can’t fix, though. Thankfully that won’t affect anything.

Re: Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

MadeMyDay — Jul 15, 2007, 08:27 AM

german language file attached. Will report later about my attempt to install it

Re: Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

Soshite — Jul 12, 2007, 09:37 PM

Don’t worry, I fully understand about stuff in real life getting in the way. Happened to me many of times before.

I’m going to be revamping my site w/ a new layout, which means I’ll be able to test to check if this fixed it.

Re: Snippet: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

sheeley — Jul 09, 2007, 02:50 PM

Hey Uncle, glad I could help. Even happier you’d already created these two snippets, it’s much easier to just debug than to create a whole new solution.

Updated: eFreg v 0.2 - eForm based Web User Registration (ppp enabled)

Uncle68 — Jul 08, 2007, 12:16 PM

Now I have updated eFreg to version 0.2 to solve some issues. Haven’t tested as much as usual, but I believe it *shold* work.

Thanks to Soshite and Sheeley for helping me debugging this script.

Please let me know if it works (or not).

To upgrade, just replace the installed efreg.inc.php with the file included in the archive.

/Uncle68

(File attached to first post.)

Re: New snippet: eFreg v 0.1 - eForm based Web User Registration (ppp enabled)

Uncle68 — Jul 08, 2007, 10:26 AM

Sheeley, sorry for not answering earlier, but I’ve been away for about two weeks. But it seems that you found the solution by your self, and also managed to shorten down the code while doing it!

There where two problems as you correctly found out:

Error #1: My code *required* that there would be at least one field added to the web_user_attributes table, if not the sql query would end with a comma, not good! Stupid misstake by me! This was the problem Soshite also was exposed to.

Error #2: I’ve somehow missed to put the country, zip, and state field into the input_opt array, how could I ever make such a stupid misstake?

I’ll update the code tomorrow! Thanks very much for finding this out!

@Soshite: I’m verry sorry for leaving you for two weeks without a solution, but I had to take care of some unexpected stuff in "real life".

New version comming soon.

Re: New snippet: eFreg v 0.1 - eForm based Web User Registration (ppp enabled)

sheeley — Jul 05, 2007, 05:33 PM

I replaced

if ($_POST[$input_prefix.'country']) $country = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'country']));
	if ($_POST[$input_prefix.'state']) $state = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'state']));
	if ($_POST[$input_prefix.'zip']) $zip = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'zip']));
	if ($_POST[$input_prefix.'phone']) $efreg_inputs_opt['phone'] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'phone']));
	if ($_POST[$input_prefix.'mobilephone']) $efreg_inputs_opt['mobilephone'] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'mobilephone']));	
	if ($_POST[$input_prefix.'dob']) $efreg_inputs_opt['dob'] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'dob']));	
	if ($_POST[$input_prefix.'gender']) $efreg_inputs_opt['gender'] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'gender']));		
	if ($_POST[$input_prefix.'fax']) $efreg_inputs_opt['fax'] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'fax']));		
	if ($_POST[$input_prefix.'photo']) $efreg_inputs_opt['photo'] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.'photo']));			
	if ($_POST[$input_prefix.'comment']) $efreg_inputs_opt['comment'] = $modx->db->escape($_POST[$input_prefix.'comment']);

with

$efreg_extra_inputs = array('country','state','zip','phone','mobilephone','dob','gender','fax','photo','comment');
	foreach($efreg_extra_inputs as $input => $putInArray){
		if($_POST[$input_prefix.$input]){ 
			 $efreg_inputs_opt[$input] = $modx->db->escape($modx->stripTags($_POST[$input_prefix.$input]));
		}
	}

and now all seems to be golden. I’m not sure what exactly was broken, but this works for me in my limited testing.

Re: New snippet: eFreg v 0.1 - eForm based Web User Registration (ppp enabled)

sheeley — Jul 05, 2007, 03:23 PM

Okay, so doing that hid the error... but the data isn’t being put in the table either. Is there a fix for this already? I’m going to take a deeper look into the code soon.