Update Profile Validation - My Forums

Update Profile Validation

todd.b — Apr 23, 2018, 03:27 PM

Revo 2.6.3
Login 1.9.5

I have a ClassExtender field (screenName) that requires a minimum of three characters which correctly throws an error if less than three. The problem is the form still submits and the field is updated despite the error.

[[!ExtUserUpdateProfile]]
[[!UpdateProfile?
	&preHooks=`FullName`
	&excludeExtended=`email:required:email,login-updprof-btn,mediaFolder`
	&validate=`nospam:blank,
		username:required,
		firstName:required,
		lastName:required,
		screenName:required:minLength=^3^,
		email:required:email`
	&useExtended=`0`
]]
[[!SetUserPlaceholders]]

Screen Name [[!+error.screenName]]

Re: Update Profile Validation

andytough — Apr 27, 2018, 10:10 AM

Thank you.

Re: Update Profile Validation

BobRay — Apr 25, 2018, 09:54 PM

On second thought, I'm not sure the isset() is necessary. You might check the $_POST array with them empty to see if they're always set. if they are, you don't need the isset().

Note that it's normal to see an empty array when the form is first loaded. It's what happens on submit that counts.

echo "POST: " . print_r($_POST, true);

Re: Update Profile Validation

andytough — Apr 25, 2018, 09:51 PM

Thank you Bob.

Re: Update Profile Validation

BobRay — Apr 25, 2018, 09:31 PM

If you don't need to check the length, this would be correct:

if ( (! isset($_POST['firstName'])) || empty($_POST['firstName'])) {
      return "";
}

Re: Update Profile Validation

andytough — Apr 25, 2018, 08:44 AM

I'm glad I came across this post. It points to a solution to a problem I had only just noticed where the data in 'required' ClassExtender fields that had been successfully populated during registration was occasionally being removed when people were updating their profiles.

To prevent the existing data in four ClassExtender fields from being overwritten I have added the following code. (field names are : firstName, lastName, businessAddressCounty, businessAddressPostcode)

It seems to work, but I wonder if there is a better way of writing the code, rather than repeating the whole thing four times?

if ($submission) {
if (strlen($_POST['firstName']) < 1) {
      return "";
   }
if (strlen($_POST['lastName']) < 1) {
      return "";
   }
if (strlen($_POST['businessAddressCounty']) < 1) {
      return "";
   }
if (strlen($_POST['businessAddressPostcode']) < 1) {
      return "";
   }
    $modx->request->sanitizeRequest();
    $dirty = false;
    foreach ($fields as $key => $value) {
        if (isset($_POST[$key])) {
            if ($value !== $_POST[$key]) {
                $data->set($key, $_POST[$key]);
                $dirty = true;
            }
        }
    }

    if ($dirty) {
        $data->save();
    }
}

return '';

Or should I be using something different like

if (empty($_POST['firstName'])) {
      return "";
   }

Re: Update Profile Validation

BobRay — Apr 24, 2018, 03:47 PM

Yes it will, though you can rename the snippet and call that new snippet in the tag. That way it won't get overwritten.

Re: Update Profile Validation

todd.b — Apr 24, 2018, 12:19 AM

Very nice, it works great. Thank you.

Just so I understand, if/when ClassExtendeder is updated this will be overwritten, correct?

Re: Update Profile Validation (Best Answer)

BobRay — Apr 23, 2018, 10:28 PM

Wait, I thought of a much easier way:

Add the three extra lines to the ExtUserUpdateProfile snippet, just below if ($submission) {.

if ($submission) {
   if (strlen($_POST['screenName']) < 3) {
      return "";
   }

... 
}

That way, the custom field won't be updated and UpdateProfile will display the error message for you.

Re: Update Profile Validation

todd.b — Apr 23, 2018, 10:12 PM

Hmmm... ok. Thanks.

Is PHP also a validator option? The problem with js is that it's easily disabled.