Unzip function for file manager

Ok, finally got Windows upgraded with the service pack 1 and IE 11 installed. Revo is installed. I had to do some fiddling with compatibility mode, then it finally worked. At first the popup dialog didn't show after clicking the unzip file context menu item. But once I got the browser to work, it unzipped all the files just fine.

Come to think of it, I also logged out and logged in again, so it may have been an issue with the permissions not being flushed after installing the patch package.

I have a question about making this part of the core. Won't this mean that the setup will have to be modified to include the file_unzip permissions in the Administrator ACL?

@Windows: Mmh, I wouldn't even bother with IE, that's more about frontend/extjs/css etc. when its not working, I was more concerned about handling filepaths differences between Windows and Linux (e.g. / slashes vs \ slashes)

@Permissions: I think I did in the PR, no? I added the new permission/lexicon entries + added the permisson to the administrator and developer policy, is there something I missed to make this work?

Yes, in the patch package. I meant in Setup. But I'm not sure how Setup works, anyway.

For slashes/backslashes, you can use the PHP constant, DIRECTORY_SEPARATOR, but AFAIK, the slash / now works universally for all platforms. You do need to translate it, though, if you're doing a string compare of paths generated by two different methods.

Quote from: sottwell at May 12, 2014, 03:03 AM

Yes, in the patch package. I meant in Setup. But I'm not sure how Setup works, anyway.

I think the setup is generated from the modx build script (don't know the details though), so I guess the changes made to the build files (sent with PR) should take care of that. If I'm wrong here, please tell me =D

Quote from: BobRay at May 12, 2014, 04:27 AM

For slashes/backslashes, you can use the PHP constant, DIRECTORY_SEPARATOR, but AFAIK, the slash / now works universally for all platforms. You do need to translate it, though, if you're doing a string compare of paths generated by two different methods.

I used the DIRECTORY_SEPARATOR when writing the code, not sure if I catched all relevant occurences though...

It worked fine on Windows for me. Windows 7, SP1, with a beta version of MAMP for Windows.

Any chance you could fix whatever's broken when installing on 2.3.1? I really miss this functionality!

Sure, will do as soon as I find time! I guess the main functionality works, but as core files are patched (which are 2.2.14 in the package, I believe) they're likely not compatible with 2.3.1...