Hi Mike,
I don’t use Revo now (I had a brief flirtation only). The conditional ’If’ tag syntax is quite unfamiliar to me I’m afraid. As such, the only code I can really comment on is the search code itself. However my first question is whether [[!Search]], with or without the exclude parents parameter works on its own i.e. reduce your code as posted to [[!Search]] to see if the fault is really with the search code or with the conditional.
I would point out a couple of things, which may or may not be helpful, but I’ll say them anyway:
- Logic in presentation i.e. conditionals in templates in a general (not just MODx) sense is something to use with caution - do a quick google as alot has been said on this elsewhere.
- The Search snippet is intended only to search the documents the user has access to anyway i.e. set access permissions on the documents in question so that only those users can see them, and all should be fine. This is well tested on Evo. Offhand, I can’t however be sure it works on Revo. If this could solve the issue anyway and you try it, please let me know what the outcome is, if only so I can advise others appropriately. Edit: Looking at the snippet source, I would expect it to work in Revo.
--Tim.
-Mike
Hi Mike,
<snip>
I would point out a couple of things, which may or may not be helpful, but I’ll say them anyway:
- Logic in presentation i.e. conditionals in templates in a general (not just MODx) sense is something to use with caution - do a quick google as alot has been said on this elsewhere.
- The Search snippet is intended only to search the documents the user has access to anyway i.e. set access permissions on the documents in question so that only those users can see them, and all should be fine. This is well tested on Evo. Offhand, I can’t however be sure it works on Revo. If this could solve the issue anyway and you try it, please let me know what the outcome is, if only so I can advise others appropriately. Edit: Looking at the snippet source, I would expect it to work in Revo.
--Tim.
Quote from: TimGS at Mar 05, 2011, 08:17 PM
Hi Mike,
<snip>
I would point out a couple of things, which may or may not be helpful, but I’ll say them anyway:
- Logic in presentation i.e. conditionals in templates in a general (not just MODx) sense is something to use with caution - do a quick google as alot has been said on this elsewhere.
- The Search snippet is intended only to search the documents the user has access to anyway i.e. set access permissions on the documents in question so that only those users can see them, and all should be fine. This is well tested on Evo. Offhand, I can’t however be sure it works on Revo. If this could solve the issue anyway and you try it, please let me know what the outcome is, if only so I can advise others appropriately. Edit: Looking at the snippet source, I would expect it to work in Revo.
--Tim.
Hey Tim,
If I search for a term that exists only on a page I don’t have permission to access and nowhere else, a blank page is returned instead of the results page with "no results found." Otherwise, it works as expected in Revo. An easy fix, maybe?
-Mike
Puzzling, as it works fine in Evo.
If you search for terms that are included in both public and private areas, but are not logged in and hence do not have access to the private pages, what happens?
If you search for terms that are included nowhere at all what happens?
What I am after is whether it is just no finds that is a problem, or whether there is a problem searching private pages that are currently inaccessible to the user.
Look for the line define(’DEBUG’, 0); and change 0 to 1. Post the output.
-- Tim.
Search Terms array: array(1) { [0]=> string(10) "pubprivtest" }
Search Terms negative array: array(0) { }
Neg query 1:
Neg query 2:
SELECT id, editedon FROM `modx`.`modx_site_content` WHERE published = 1 AND searchable = 1 AND deleted=0 AND (((`modx`.`modx_site_content`.pagetitle LIKE '%pubprivtest%') OR (`modx`.`modx_site_content`.longtitle LIKE '%pubprivtest%') OR (`modx`.`modx_site_content`.introtext LIKE '%pubprivtest%') OR (`modx`.`modx_site_content`.content LIKE '%pubprivtest%')))
First Pass: array(1) { [14]=> array(2) { ["count"]=> int(1) ["date"]=> string(10) "1296837339" } }
Search Terms array: array(1) { [0]=> string(8) "privatetest" }
Search Terms negative array: array(0) { }
Neg query 1:
Neg query 2:
SELECT id, editedon FROM `modx`.`modx_site_content` WHERE published = 1 AND searchable = 1 AND deleted=0 AND (((`modx`.`modx_site_content`.pagetitle LIKE '%privatetest%') OR (`modx`.`modx_site_content`.longtitle LIKE '%privatetest%') OR (`modx`.`modx_site_content`.introtext LIKE '%privatetest%') OR (`modx`.`modx_site_content`.content LIKE '%privatetest%')))
First Pass: array(2) { [20]=> array(2) { ["count"]=> int(1) ["date"]=> string(10) "1299685039" } [21]=> array(2) { ["count"]=> int(1) ["date"]=> string(10) "1299790412" } }
If the search term is in a TV on a private page, it is ignored unless I am logged-in. But, if the term is in a normal document field like pagetitle or content, it shows up whether I have permissions or not and fouls things up.
If the search term is in a TV on a private page, it is ignored unless I am logged-in.
if the term is in a normal document field like pagetitle or content, it shows up whether I have permissions or not and fouls things up.