[Plugin] Google Analytics

That actually won’t work because the pageoutput has already been parsed so the API does nothing. (Or at least it did nothing in my tests...)

Btw, what is this thing do?


I tried this one, when I first access uncached page, it won’t show anything, and I access it again, this thing won’t show up as well, until I decided to login as a manager and able to see all the fancy stuff from quickeditor, then I’m starting to see this script. I logged out from my system, and access the page again, and it’s still there, no matetr how many time I login/logout from the system. I’m just curious whether this will do us any harm or not, because I have no idea of what it’s doing.

Thanks

FYI, the regClientStartupScript is not functionaning properly, until you do the fix, which I believe it will be applied to 0.9.2. So if you use the API, you need to let the user know they need to fix their 0.9.1 API first

Quote from: Mark at Feb 09, 2006, 07:59 PM

That actually won’t work because the pageoutput has already been parsed so the API does nothing. (Or at least it did nothing in my tests...)

Hemm.. From my opinion, the API will not cached the script if it’s being called from an uncached snippet.

In the doc parser, it will basically parse the doc twice.

The first one will be to create a page with all uncached snippet calling, then the parser will cached the page, if there is a cache for the page, then it will use that, instead of parsing the system again.

The second one will be to substitute all the uncached snippet into cached snippet symbol and parse the document output again with the uncached snippet being modified into cached snippet. During this time, the register client script will be called on uncached snippet and stored in an array. So after this second parse, I saw that the the array being processed again, and this final page is not being cached anymore. So it means that whatever output being produced by uncached snippet will not be cached, even if we use regClientScript and etc.

It’s jut my though though, and so far I haven’t have any problem yet.

Quote from: Djamoer at Feb 09, 2006, 08:00 PM

Btw, what is this thing do?

<script type="text/javascript">var MODX_MEDIA_PATH = "media";</script>

I tried this one, when I first access uncached page, it won’t show anything, and I access it again, this thing won’t show up as well, until I decided to login as a manager and able to see all the fancy stuff from quickeditor, then I’m starting to see this script. I logged out from my system, and access the page again, and it’s still there, no matetr how many time I login/logout from the system. I’m just curious whether this will do us any harm or not, because I have no idea of what it’s doing.

Thanks

FYI, the regClientStartupScript is not functionaning properly, until you do the fix, which I believe it will be applied to 0.9.2. So if you use the API, you need to let the user know they need to fix their 0.9.1 API first

Hmm...guess I’ll have to put the Mint plugin on hold till we get some of these problems resolved. Bummer!

The regClient fix is really simple, one character if I recall properly and definitely will be fixed for 0.9.2.

that was one fix, the other was four places where documentContent was used instead of documentOutput.

Quote from: rthrash at Feb 10, 2006, 02:25 PM

The regClient fix is really simple, one character if I recall properly and definitely will be fixed for 0.9.2.

So the one that I did is wrong or not?
http://modxcms.com/forums/index.php/topic,1942.msg18781.html#msg18781

no, you need both fixes.

Quote from: sottwell at Feb 10, 2006, 03:38 PM

no, you need both fixes.

Ehm ok, I’m not to for sure though, but I’m able to get it to work now, so I’m happy with it

I have a quick question. How do I turn on this plugin?

Created a new plugin, dropped the code in it, activated "OnWebPagePrerender" in the system events, saved and checked my homepage’s source code but nothing happens.

Did I missed something? I’m running MODx 0.9.2.1

Thanks!
Boby