We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 12808
    • 70 Posts
    Can someone confirm or deny this (get it from my friend who is a hosting server admin):

    New Advisory:
    modx-0.9.6
    http://www.dear-pets.com
    ——————–Summary—————-
    Software: modx-0.9.6
    Sowtware’s Web Site: http://www.modxcms.com
    Versions: 0.9.6
    Critical Level: Moderate
    Type: Multiple Vulnerabilities
    Class: Remote
    Status: Unpatched
    PoC/Exploit: Not Available
    Solution: Not Available
    Discovered by: http://www.dear-pets.com
    —————–Description—————
    1. SQL Injection.
    Vulnerable script: mutate_content.dynamic.php
    Parameters ‘documentDirty’, ‘modVariables’ is not
    properly sanitized before being used in SQL query. This can be used to
    make SQL queries by injecting arbitrary SQL code.

    Condition: magic_quotes_gpc = off
    ————–PoC/Exploit———————-
    Waiting for developer(s) reply.
    ————–Solution———————
    No Patch available.
    ————–Credit———————–
    Discovered by: http://www.dear-pets.com
      --
      www.spotkg.com
      • 28042 ☆ A M B ☆
      • 24,524 Posts
      documentDirty is a Javascript variable, used to determine if changes have been made in any of the form fields in the client before the form is submitted. What does it have to do with sql queries?

      modVariables doesn’t even occur in the file at all. huh

      And where is this advisory?

        Studying MODX in the desert - http://sottwell.com
        Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
        Join the Slack Community - http://modx.org
        • 22303 MODX Staff
        • 10,725 Posts
        I can confirm that this is absolutely not a vulnerability in any way, shape or form.
          • 12808
          • 70 Posts
          I get this as a response from my host admin:

          [email protected](/host/imandic.com/sites/gridkg.com)# grep -R modVariables *
          httpdocs/manager/actions/mutate_content.dynamic.php:var modVariables = [];
          httpdocs/manager/actions/mutate_content.dynamic.php: var i, isDirty, mv = modVariables;

          The whole story is that he wants me to abandon MODx and start using Drupal, and I’m fighting back...Love MODx..
            --
            www.spotkg.com
            • 28042 ☆ A M B ☆
            • 24,524 Posts
            Well, in any case, those are Javascript variables and have nothing at all to do with any sql queries.

            Maybe a bit of javascript that has been removed; I was looking at the file from the latest 0.9.6.1 from SVN.
              Studying MODX in the desert - http://sottwell.com
              Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
              Join the Slack Community - http://modx.org
              • 28033
              • 925 Posts
              Quote from: imandic at Oct 09, 2007, 05:19 PM

              The whole story is that he wants me to abandon MODx and start using Drupal, and I’m fighting back...Love MODx..

              Sounds like said host plays favorites.  wink

              Trying to find a miniscule thing like that, and not even checking to see if it really even exists.
                My Snippets
                -> PopUpChunk v1.0
                • 22303 MODX Staff
                • 10,725 Posts
                I don’t know who the reporters are yet, but you can bet they are getting a piece of my mind for this bogus security report which is now taking up half of my day to deal with...
                >:(
                  • 33372
                  • 1,611 Posts
                  This is definitely a completely bogus report (unlike some of the ones below for Drupal):
                  http://search.securityfocus.com/swsearch?sbm=%2F&metaname=alldoc&query=drupal&x=0&y=0
                  http://osvdb.org/searchdb.php?action=search_title&vuln_title=drupal&Search=Search
                    "Things are not what they appear to be; nor are they otherwise." - Buddha

                    "Well, gee, Buddha - that wasn't very helpful..." - ZAP

                    Useful MODx links: documentation | wiki | forum guidelines | bugs & requests | info you should include with your post | commercial support options
                    • 28042 ☆ A M B ☆
                    • 24,524 Posts
                    The dear-pets.com guy is probably a script kiddie who thinks he’s a programmer. Posts in the vulnerability site and never even mentions it to anybody from MODx. Just looking at the message, you can see those are Javascript variables, not parameters and nothing to do with PHP or SQL. rolleyes

                    (well, I suppose I knew that because I already know that’s what they are... but if you look at the code in question, it’s obvious.)
                      Studying MODX in the desert - http://sottwell.com
                      Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
                      Join the Slack Community - http://modx.org
                      • 28042 ☆ A M B ☆
                      • 24,524 Posts
                      Oh, great. It was even been posted to SecurityFocus. If I wasn’t suspecting sheer stupidity, I’d be thinking somebody was deliberately trying to spread FUD about MODx!
                        Studying MODX in the desert - http://sottwell.com
                        Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
                        Join the Slack Community - http://modx.org