@INHERIT wont work using TV in WayFinder

I am calling a Template Variable in my WayFinder row template. But when I use @INHERIT as the default value for the TV it isn’t pulling the value from the parent, it is just loading it empty.

Here is my Row Template:


You’ll notice I am calling the HeaderImage and HeaderText Template Variables. Which works perfectly fine if they are assigned a value. But if they are using the default value of @INHERIT, they are loading empty!

Does anyone know if this is a bug with WayFinder or am I missing something silly here...?

Any Ideas?

Sounds like a bug; like it may not be processing the TV values properly.

Is the parent published? I had a similar issue and it turned out that it was not inheriting the data since the document was not published.

INHERIT seems to work in the menu template, but only if you are on a page under the parent that it is inheriting from.

In other words, I think it is trying to INHERIT from the parent of the page you are viewing instead of its actual parent in the hierarchy.

Is this a bug that would be easily fixed?

I think that this is the way it is supposed to work.

If I have the following structure:

home
about
--sub 1
----subsub1
--sub 2
services
--sub 3
--sub 4
contact

And they are all using the same template variable that has @INHERIT set as the default value. Sub 1 will inherit it from ’about’, sub 3 will get the value from ’services’. But subsub 1 will look to sub 1 for a value, if not found then it will go to ’about’.

However, if you have a value in sub 1, subsub 1 will get the value from sub 1 rather than from about.

You are correct. @INHERIT will go up the tree and use the first value it finds.

This is a fundamental problem with the current architecture. @INHERIT uses the $modx->documentIdentifier to start looking for parent values for the TV. But in the case of getting these values on pages other than the actual page itself (i.e. via Wayfinder or Ditto), the @INHERIT will be using the wrong document id to start the search. This architectural issue is another of the reasons I endeavored to build Revolution, so each document could be treated as an object and be responsible for parsing it’s own content, even when accessed from snippets on other pages.

so each document could be treated as an object and be responsible for parsing it’s own content, even when accessed from snippets on other pages.

Very cool.

I submitted a change to fix this problem in Ditto a couple of months ago.
http://mirror3.cvsdude.com/trac/ditto/codebase/ticket/84
It’s only a partial fix, but solves a certain class of problems for me. And sorry it’s not a Wayfinder fix. I wonder if something similar could be done for WF?