This thread will deal with allowing the renaming of the manager folder, for those that want or need this type of functionality. Since it affects a huge amount of files and other resources (snippets, plugins, modules. etc) my thinking is that there needs to be at least some input from the dev team and community members.
Working from the 0921 edition, I have changed 21 files in the manager folder (actions - dynamic/static, includes, processors) and a few snippets so far which had the manager path hardcoded. There are quite a few other areas which still need modifying but as it stands now I have it working very well.
Once I get all the files I can see that are affected changed, I’ll get the newest version from the SVN and do a line numbered changelog for whomever is interested.
Note that this modification will require all instances of the manager path in every type of resource which is hardcoded to be altered, so perhaps it is wise to ask a few questions before it goes too far:
1. what would be a good constant name to apply for the folder? ( I currently use $manager_folder_name)
2. how many people would actually use this feature?
I am open to all input so whomever is interested in helping or any ideas would be appreciated... as soon as I get more done I’ll be sure and update this thread.
ok, thats not a problem... I just wanted to make sure it was gong to work as expected, my 0921 test site is just that - a site that if I messed it up would not be an issue.
The way its set up at this point is:
a constant in the config.inc.php and also a matching one at the top of the root index(or whatever you named it).php file. I had to do it this way or it would not work... more investigation needed there I assume. And in the document parser I had to set a few globals too, perhaps more investigation there too.
Setting up a seperate SVN would be okey dokey, that way you and the dev team could keep tabs on it in case there is a part which could be optimized or whatever...
-
☆ A M B ☆
- 24,524 Posts
Actually, the index.php files need that to know where to find the config.inc.php file! So no matter what you do, you’re going to need it in the index.php files. Putting it in the config.inc.php file won’t be of much use, since it’s already set in the calling index.php files.
see, thats what I’m talking about
seems to work fine with the name set at the top of the two index files (and removed from the config), I already had it in there just commented out. I tried so many combinations that it was hard to keep track of what worked, so I basically added it a few places and then systematically commented out places until I found the ways it would work.
I then just concentrated on editing the files, and figured the placement would be decided upon at a later date
I also uncovered another area which would require attention if this is used, when the manager is renamed it is then open to editing in the file manager. Should be an easy fix though...
-
☆ A M B ☆
- 24,524 Posts
Yes, if it’s defined in the global space, just use the constant/variable whatever to define what cannot be accessed from the file manager. (I did this once, over a year ago)
works perfectly...
on a side note about the file manager, I like to be able to edit and see all files so I added a check for the manager session id and gave myself clearance to all files and it works nice. would this be another feature that would be useful?
MODX Staff
