[RESOLVED] MODx makeUrl syntax

833 Posts

treigh Reply #1, 15 years, 10 months ago

Hey guys, as you can probably tell from the code below, I’m not PHP-savvy, but thanks to Revo’s intuitive base Class, I’m determined to extend my little knowledge.

So I’ve written a snippet to output an RSS link based on the parent document.
When I test it out, there’s no output. Not surprising, I kinda expected I would screw up the first time around. Can someone tell me what’s wrong with the code?

<?php
/*  :) */

$parentId = $modx->getParentIds($id); 
$parentUrl = $modx->makeUrl($parentId);

if ($parentId == 2) {
    echo $parentUrl."editorial.rss";
} elseif ($parentId == 3) {
    echo $parentUrl."information-politique.rss";
} elseif ($parentId == 4) {
    echo $parentUrl."echos-de-la-resistance.rss";
}
elseif ($parentId == 5) {
    echo $parentUrl."democratie-droit-de-l-homme.rss";
}

Thanks

A MODx Fanatic

☆ A M B ☆
3,112 Posts

goldsky Reply #2, 15 years, 10 months ago

I don’t think you need the makeUrl that way.

I’d use $modx->sendRedirect($modx->makeUrl($pageId)) to the rss page (if you create it as MODx’s resource).

// notice, it’s the page ID, not parent ID.

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

833 Posts

treigh Reply #3, 15 years, 10 months ago

Hey goldsky,

I should have mentioned the structure of my documents:

Parent 1
- doc1.html
- feed1.rss
Parent 2
- doc2.html
- feed2.rss
Parent 3
- doc3.html
- feed3.rss
...

The link to each one of those feeds will change depending on the current document’s parent. How do you think I should tweak this?

Thanks

A MODx Fanatic

☆ A M B ☆
3,112 Posts

goldsky Reply #4, 15 years, 10 months ago

Do you mind to put their IDs? tongue

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

833 Posts

treigh Reply #5, 15 years, 10 months ago

Sorry man. You’re right, using IDs is more efficient.

Understanding I need to get rid of $parentUrl = $modx->makeUrl($parentId);, how would I incorporate $modx->sendRedirect($modx->makeUrl($pageId)) to this code?

Do I have to define $pageId and how?

I should add that this is what I’m trying to get: <a href="[[RSSLink]]">RSS</a>

A MODx Fanatic

24,544 Posts

BobRay Reply #6, 15 years, 10 months ago

Try this:

$parentId = $modx->resource->get('parent');

No need to get all the ancestors. The $modx->getParentIds() method returns an array of all ancestors. That’s why you got no output.

You should be able to use your original if statement. Once it works, just change the echos to $url = and put this at the end:

$modx->sendRedirect($url);

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

833 Posts

treigh Reply #7, 15 years, 10 months ago

Thanks Bob, it is working with the original if statement and the echos.

I’m just not sure I followed your last part.

Should I use $url instead of $parentUrl and change echo to that?

In other words, is this what you meant:

if ($parentId == 2) {
    $url= $modx->sendRedirect($url);
}

A MODx Fanatic

24,544 Posts

BobRay Reply #8, 15 years, 10 months ago

Almost. I meant:

<?php
$parentId = $modx->resource->get('parent');

$parentUrl = false;

if ($parentId == 2) {
    $parentUrl = "editorial.rss";
} elseif ($parentId == 3) {
    $parentUrl = "information-politique.rss";
} elseif ($parentId == 4) {
    $parentUrl = "echos-de-la-resistance.rss";
} elseif ($parentId == 5) {
    $parentUrl = "democratie-droit-de-l-homme.rss";
}

if ($parentUrl) {
    $modx->sendRedirect($parentUrl);
}

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

☆ A M B ☆
3,112 Posts

goldsky Reply #9, 15 years, 10 months ago

I wonder why would you need this API for RSS?
You can easily embed RSS to MODx’s page by several ways, but easiest way is like this:

Template:

<head>
<title>[[*pagetitle]] - [[++site_name]]</title>
<meta http-equiv="Content-Type" content="text/html; charset=[[++modx_charset]]" />
<base href="[[++site_url]]" />
<link rel="alternate" type="application/rss+xml" title="RSS 2.0" href="[[~[[*rss-page-tv]]]]" />
</head>

To the RSS resource, you can apply its page to act as a RSS format:
EDIT (or CREATE) > Settings > Internet Media Type > application/rss+xml
The page itself might contain the Wayfinder / getResources with the RSS template.
eg, the result could be:

<?xml version="1.0"?>
<rss version="2.0">
<channel>
<title>Example Channel</title>
<link>http://example.com/</link>
<description>My example channel</description>
<item>
<title>News for September the Second</title>
<link>http://example.com/2002/09/01</link>
<description>other things happened today</description>
</item>
<item>
<title>News for September the First</title>
<link>http://example.com/2002/09/02</link>
</item>
</channel>
</rss>

The rss-page-tv Template Variable should be embedded to RSS enabled template.
By using HTML’s header, the RSS icon would be displayed in the browser’s address bar.

If you want to make it as a link, it would be

<a type="application/rss+xml" title="RSS" href="[[~[[*rss-page-tv]]]]">RSS feed for this page</a>

That’s super easy.

Or, you’re indeed try to create more complex purposes?

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

☆ A M B ☆
3,141 Posts

Mark Hamstra Reply #10, 15 years, 10 months ago

@Goldsky: I think he’s trying to make the actual links to the rss feed.

Like your last example:

<a type="application/rss+xml" title="RSS" href="[[~[[*rss-page-tv]]]]">RSS feed for this page</a>

Except that instead of using a template variable (which seems like a more efficient solution) he has hardcoded the link to the rss resource depending on the parent the resource is in.

Mark Hamstra • Developer spending his days working on Premium Extras and a MODX Site Dashboard with the ability to remotely upgrade MODX and extras to make the MODX world a little better.

Tweet me @mark_hamstra, check my infrequent blog at markhamstra.com, my slightly more frequent ramblings at MODX.today or see code at Github.