Bug in Output Filters?

46 Posts

loxy Reply #1, 15 years, 10 months ago

Hi!

The use of the output filter ’empty’ is not working properly I guess.

Imagine *longtitle is set to "My Title". Then the following code (each of them) produces an output:

[[*longtitle:default=`Foobar`]]
[[*longtitle:empty=`Foobar`]]
[[*longtitle:ifempty=`Foobar`]]

The output is "My Title". But it should be nothing since *longtitle isn’t empty...
If *longtitle is empty it works and the output is "Foobar"

loxy

4,149 Posts

splittingred Reply #2, 15 years, 10 months ago

Try:

[[!*longtitle:empty=`Foobar`]]

shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com

46 Posts

loxy Reply #3, 15 years, 10 months ago

Same effect...

24,544 Posts

BobRay Reply #4, 15 years, 10 months ago

Try:

[[!*longtitle:ifnotempty=`Foobar`]]

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

46 Posts

loxy Reply #5, 15 years, 10 months ago

This works. But this also:

[[*longtitle:ifnotempty=`Foobar`]]

This too:

[[*longtitle:notempty=`Foobar`]]

But I need the opposite:

[[*longtitle:ifempty=`Foobar`]]

24,544 Posts

BobRay Reply #6, 15 years, 10 months ago

I’m not following you.

What do you want if it’s empty?
What do you want if it’s not empty?

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

46 Posts

loxy Reply #7, 15 years, 10 months ago

Imagine the following code:

[[*longtitle:notempty=`<h1 style="margin-top:0.7em">[[*longtitle]]</h1>`]]
[[*longtitle:empty=`<br />`]]

If longtitle is set, I want to set it between h1
If it is empty, I want make some room...

or something like this:

<div class="subcolumns [[*longtitle:empty=`gap`]]">

loxy

24,544 Posts

BobRay Reply #8, 15 years, 10 months ago

Quote from: loxy at Nov 26, 2010, 02:21 PM

Imagine the following code:

[[*longtitle:notempty=`<h1 style="margin-top:0.7em">[[*longtitle]]</h1>`]]
[[*longtitle:empty=`<br />`]]

Have you tried the code above (using both tags)? It should work.

This may work as well:

[[*longtitle:ifnotempty=`<h1 style="margin-top:0.7em">[[*longtitle]]</h1>`:else=`<br />`]]

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

46 Posts

loxy Reply #9, 15 years, 10 months ago

This produces:

Parse error: syntax error, unexpected ’)’ in /homepages/29/d99224596/htdocs/twinpics/dev/avec/core/model/modx/filters/modoutputfilter.class.php(159) : eval()’d code on line 1

even if it is set commented out

 <!-- [[*longtitle:ifnotempty=`<h1 style="margin-top:0.7em">not empty</h1>`:else=`empty`]] -->

It is a bug...besides other forms of commenting should be implemented...

24,544 Posts

BobRay Reply #10, 15 years, 10 months ago

The ifempty modified apparently doesn’t accept an "else" argument and MODx tags are parsed whether they are in HTML comments or not.

Both of these work for me:

[[*longtitle:notempty=`<h1 style="margin-top:0.7em">[[*longtitle]]</h1>`]][[*longtitle:empty=`<br />`]]

[[*longtitle:is=``:then=`[[<br />]]`:else=`<h1 style="margin-top:0.7em">[[*longtitle]]</h1>`]]

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting