The Google Conversion Code ']]' is picked up by MODX-Tag-processor in a chunk

Hello MODXers,

We are building our first websites in MODX Revolution and encounter a small problem with the FormIt snippet.
In MODX-Revolution we used the eForm snippet. The examples on eForm showed that you had to define three chunks (Form, Report and Thanks) and they work together in the process. In each Chunk you can put HTML code which will not be interpreted.

In the ’Thanks’-chunk we put Google Adwords Conversion Codes to signal Google Adwords that a Sale is done. That code looks like this:


in MODX Revolution we use FormIt.
the call looks like this:

As you can see, the successmessage is a call to the Thanks-chunk.
But in Revolution, code in that chunk is also interpreted by the MODX-tag-processor.
And in the Google Conversion Code there is the following line:

Reason for this code is here: http://javascript.about.com/library/blxhtml.htm

On the screen we get weird results because of the MODX-tag-interpreter wich picks up the ’]]’ in the Google Conversion Code.

A solution might be a redirect to a new page but we really don’t want that because the forms are part of the page and then we need to duplicate the page.

Does anybody have a solution for this?

Thanks,

Bert Catsburg

What happens if you put the JS in an external .js file and just reference it, instead of including it inline?

e.g.



If you’d like to still keep it all inside MODx, you can try storing that JS bit in a MODx document, change filetype to JS, and use:


^ that’s Evo syntax, check the Revo docs about the appropriate link syntax

Yes, that is all possible. But that means that I have to change the Google Conversion Code.
And what we would like is to cut-and-paste the code from Google straight into a Chunk.
In Evo-eForm that worked ok.
We don’t like to do some post-processing on the JS code.

In general the question would be: What if you need XML-CDATA in your content, which closes with ’]]’ and how to prevent the MODX-Tag-Processor to react on the ’]]’.

Thanks,

Bert

First, is this an issue specifically with FormIt or the core?

Good question.
We encounter the issue in Formit.
But support you want to display the following text on your screen

And that text is coming out of a chunk. Then MODX pick up the ’]]’, just like we see in the Formit chunk as described above.

That works for me in a simple chunk being output to the page; since there is no unclosed bracket before the CDATA end tag, those are skipped by the parser. So perhaps it is a more complex problem that is being described here. Can you provide a little more detail about where the closing CDATA tag is causing the problems? Things like where the chunk is being placed (e.g. is it returned inside another tag)?

The chunk is called in the successMessage parameter of the Formit snippet.
Maybe it has something to do with the way Formit processed this successMessage parameter.
If this is not enough info for you, I will have to do some testing over the weekend and get back to you on this.

I ran into this same problem. The easiest solution by far was putting the js into an external file.

Be sure you’re testing with the newest version of FormIt (released last night). There is a change in tag-processing that may factor in.

If you have last night’s version, check out line 172 of the formit snippet:



It should be ’]’ (missing semicolon). That could be causing an unclosed tag there.

Quote from: Everett at Dec 10, 2010, 02:27 PM

I ran into this same problem. The easiest solution by far was putting the js into an external file.

Moving to an external file creates and additional HTTP request, slowing down the site and potentially messing up conversion tracking due to execution timing.