QuickEdit for TP3.2

Hi Adam,

I’m managed to successfully integrated your QuickEdit module into the TP3.2 build on my PC. It’s looking very nice. There however seems to be a bug when TV check options.

One question though Adam is why did you make it into a Module and not a single plugin? It would appear to me that there is no interface for the module or will this be added later? If so then that ok but if there will be no interface for the QuickEdit module then I think it would be better suited as a plugin.

Keep up the good work.

Please see the attached as it containssome changes that I’ve made the toinstallation files

We are also going to need a little documentation on how to use the QuickEdit feature.

Thanks I’ll give those files a look and include the chages.

I believe that the module/plugin combination is necessary because there are two distinct, almost independent elements to the frontend editing. The real necessary part of it is the module which is the actual editor. There has to be an actual page with an actual url that can be called to get to the editor, that’s what the module is for. This could be done with a custom template but a module seems like a much better option. You can see this in action by typing this URL into your own site

/manager/index.php?a=112&id=1&doc=1&var=content (replace id= number with the id for your QuickEdit module)

This is the complicated part of the process. The plugin does nothing more than add the links to the appropriate places in the output. If you don’t like the edit links where they are you can always just add the links to the theme manually using the url above and give it a target="_blank". Or better yet add a <!-- QuickEditLink:content --> comment so that the links won’t show to unprivileged users.

If there is a way to get the editor window to work as a plugin I’d be happy to look into consolidating it, but I’d need a little explanation as to how to get that to work.

I have been planning on working up some documentation, especially for template designers. Hopefull I’ll have that done soon. Running the module from within the editor would then give you documentaiton on how to use QuickEdit in your templates.

I’ve been working on the code and I have some good improvements in place already. I should just have to integrate some of these changes and then work on the documentation and it’ll be ready to go for 3.2.

sounds great!

Re: the edit links.

These links should not be shown if the user does not have edit_document permission. Use the $modx->hasPermission(’edit_document’) function to check for edit access and/or check for TV acesss using the site_tmplvar_access table.

You’re right. I had the TV links being hidden but it wasn’t working with built-in content. I spent most of the night trying to really nail down the permissions. It’s been giving me a bit of trouble but hopefully after a little sleep I’ll be able to get to the bottom of it.

I did get your changes integrated and that is worknig very well. I think I’m very close to a fairly solid release. If I can get the permissions working smoothly and then work on the documentation we’ll be donig pretty good.

Cool sounds very good.

Well, I’ve it integrated into the core TP3.2 install and have also created a separated installer. See the attached file for the QuickEdit installer.

It works real well after installing TP3.2. It’s a very nice module indeed

Hi Adam,

This little css is needed for pointer to show in IE :

a.QuickEditLink{
cursor:pointer;
}

A few things I’d really like to see, and that would merit a 3.3 release along with a few other little things, would be the following additions to the QE. First, it should have a little fixed-positions (static) tab that when clicked shows a few options such as:

• Go to Manager
• Hide QE links (or Show if Hidden)
• End QE Session (logout of manager in reality)

Later, we could also add:

• Move Document
• Delete Document
• Create Document Here
• Create Folder Here
• Unpublish Document
• Show unpublished Documents

I would prefer to see the QE remain a local-document editor function; "Unpublish document", "go to Manager" and "logout" would be nice. But adding all the other document functions of the Manager, I think, would be an unnecessary redundancy. Some of the document functions require access to the Tree, so as far as I can understand this, making these available from QE would actually require loading the Manager anyway.

To clarify, QE should be for the document being viewed, not a front-end version of all the Document Management functions of Manager.

Quote from: sottwell at Aug 25, 2005, 01:56 AM

To clarify, QE should be for the document being viewed, not a front-end version of all the Document Management functions of Manager.

But what if you could make it so that you can build your website Visually? Meaning you can add documents, content just like DW, FrontPage or some other WYSIWYG editor.

Just imagine you start with a single home then you add a new page which is immediately displayed inside your website menubar. You can then click on website menubar to load that page, change the title and modify the content to fit the site’s layout.