TP3 is now in SVN

Hi,

I’ve uploaded my latest changes to my svn branch (raymond). Please check it out so we can test, fix and add whatever needs to be added for the final TP3.

Here’s a list of what was added:

* add menu title to document. this is a short title that can be used when building menus.
* add built-in META tag feature to insert meta tags if available
* add built-in keyword feature to document to insert keywords if available. Not longer need the GetKeywords snippet
* add built-in Track visits feature to document. This can be used to turn on or off page hits. Not longer need the DontLogPageHit snippet
* add new roles
new_plugin
edit_plugin
save_plugin
delete_plugin
new_module
edit_module
save_module
delete_module
exec_module
view_eventlog
delete_eventlog
manage_metatags
edit_doc_metatags
new_web_user
edit_web_user
save_web_user
delete_web_user
* fix security bug when one a document is assigned to two doc groups but only one of those doc groups is flagged as private
* added menutitle,privateweb,privatemgr and donthit fields to site_content. The private fields will be used to mark the document as private
* add grid and search features to user screens
* fix template warning bug
* change siteCache.idx to siteCache.idx.php
* add Manager session variables to separate web sessions variables from manager
mgrConfigCheck
mgrShortname
mgrFullname
mgrEmail
mgrValidated
mgrInternalKey
mgrFailedlogins
mgrLastlogin
mgrLogincount
mgrRole
* enable custom toolbar set for FCKEditor
* convert TinyMCE and FCKEditor plugins. FCKEditor be the default editor

* add new events OnSiteSettingsRender, OnFriendlyURLSettingsRender, OnUserSettingsRender, OnInterfaceSettingsRender, OnMiscSettingsRender, OnRichtextEditorRegister, OnRichtextEditorInit
* change TV Display type to widget
* allow installer to create a separate site id for new installations
* add OnPageUnauthorized and OnPageNotFound events
* add ini_set("track_errors","1") inside DocumentParser to tracks errors - e.g evalPlugin
* fix call-time pass-by-reference in bkmanager.static.action.php on line 295 and import_site.static.action.php on line 172
* add feature to snippets to allow the echo command to return data from the snippet
* remove my_phase.gif and logo.gif from media/images/icons
* remove site_addressbook table and associated roles - such features can now be implemented as a plugin
* add event viewer
* add OnBeforWebLogin, OnWebAuthentication, OnBeforeManagerLogin, OnManagerAuthentication
* allow datagrid column parameters (such as column names, column types, etc) to use the "||" separator when separating values. The "," separator is still supported.
* move tvscripts to script/bin
* add shared property feature to modules. this will allow a module to share or make public it’s configuration settings to plugins and snippets. Plugins or Snippets can only connect to a module’s shared property if it’s assigned to the module.

* update weblogin to return to the url found in the &refurl agrument if it was called from an unauthorized page
* add &refurl agrument to url when calling the error and unauthorized pages. The &refurl agrument will contain the url of the page that was last access.
* add resource selector
* add module support with denpendency screens
* move actions/dynamic/resources.dynamic.action.php to actions/static/resources.static.action.php
* add OnBeforeModFormSave, OnModFormSave events
* add OnBeforeModFormDelete,OnModFormDelete events
* add OnModFormPrerender,OnModFormRender,
* add {DBASE} tag to @SELECT bindings

* fix security bug in Image Manager
* add check for $_SESSION["ImgMngrPathMode"] variable to image manager. This will allow the image manager to override the default IM setting to use the meadia/resicons/ folder when working with resource icons
* fix bug in header.inc.php and system alerts
* added new session variables. these will separate manager from web login
webValidated
webInternalKey
webShortname
webFullname
webEmail
webValid
webUser
webFailedlogins
webLastlogin
webnrlogins
webDocgroups
* fix bug in tree when using non html characters such as (")
* suppress set_time_limit errors when using safemode
* fix installer owverwrite bug.

Wonderful work... Install went without a hitch. Amazing job -- e’ry t’ing irie mon! Toss in Zi’s quick manager reskin as the default layout and we’ll be in great shape to release a new Tech Preview and to start getting some folks building modules and plugins, forever breaking the visual ties to Etomite.

Raymond, congrats on the great work. A few recommendations that’ve been there all along for the installer and installer-related things:

update: Some of the below are already done!

1) Put the DB testing step on the DB page so it can happen prior to it going there.
2) Move the install folder warning to the top of the home screen. If no warning, remove it entirely.
3) Find some code that works to create the config file as needed on PHP/Linux/Unix servers. Ditto for changing permissions.
4) If possible, prompt to delete the install directory when completed, and do so.
5) Move the friendly URL usage to the installer part, and automatically rename the ht.access files via the installer (we need to remove the Etomite refs in that file, too).

Some overall minor usability tweaks that would be great as well:

1) Automatically check for duplicate aliases. This causes bad problems when SEF URLs are on. Create aliases automatically out of the Page name making it all lowercase and replacing spaces with dashes and stripping special characters.
2) Have menu indexes at the same level increment automatically.
3) Have the offline message be a page in system instead of a simple message... better branding control.
4) Figure out and kill the infiinite "Working..." loop when updating the system configuration. (Occurs in Firefox and Safari every time for me.)
5) Fix layout oddities on system config pages when viewed in Safari. For example, the Site Settings / Resolve hostnames renders in one very narrow column the width of the word "hostnames".

For those of you that would like it, here’s a Snapshot of Raymond’s branch exported from SVN to try the new installer. It’d be nice to test both new installs and upgrades. Enjoy!

Quote from: rthrash at Jun 30, 2005, 03:34 PM

For those of you that would like it, here’s a Snapshot of Raymond’s branch exported from SVN to try the new installer. It’d be nice to test both new installs and upgrades. Enjoy!

FYI, I received this database alert during my first upgrade attempt...



At that point the Close button at the bottom of the install screen was non-functional, but the manager and site itself seem to be working flawlessly.

Also, when enabling the rich-text editor in System configuration under Interface & editor settings, I don’t see the FCKeditor option, even though it exists in the /assets/plugins directory (in fact there is no editor listed when I enable the option) and I left the checkbox checked next to the Install/Upgrade FCKeditor during the upgrade process.

Quote from: OpenGeek at Jun 30, 2005, 04:57 PM

I don’t see the FCKeditor option, even though it exists in the /assets/plugins directory (in fact there is no editor listed when I enable the option) and I left the checkbox checked next to the Install/Upgrade FCKeditor during the upgrade process.

Was this done on a clean install or on a upgrade?

Quote from: OpenGeek at Jun 30, 2005, 04:40 PM

Quote from: rthrash at Jun 30, 2005, 03:34 PM

For those of you that would like it, here’s a Snapshot of Raymond’s branch exported from SVN to try the new installer. It’d be nice to test both new installs and upgrades. Enjoy!

FYI, I received this database alert during my first upgrade attempt...

Column count doesn't match value count at row 1 during the execution of SQL statement REPLACE INTO `modx_user_roles` VALUES (1, 'Administrator', 'Site administrators have full access to all functions', 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1).

At that point the Close button at the bottom of the install screen was non-functional, but the manager and site itself seem to be working flawlessly.

Ok now I see. The install did not complete successfully. I’ll have a look at this. Some unused field where removed from the user_roles table. you can manually comment out that line.

As for FCK you need to manually enable the events OnRichTextEditorInit, OnRichTextEditorRegister, OnInterfaceSettingsRender due to the failed install.

It would also appeat that the FCK editor was not installed at all

Ok,

I’ve just completed 2) Have menu indexes at the same level increment automatically.

Have a look at the attached clip. I’ve also fixed the problem of parent folder assignment.

What do you think?

Man, that’s great Raymond! The folder fix is especially great... no more panicked "where’s my page... it disappeared!"

Quote from: xwisdom at Jun 30, 2005, 06:09 PM

Was this done on a clean install or on a upgrade?

This was an upgrade, just FYI -- and though the FCKeditor files were in the plugins directory, they just didn’t show up in the settings...