We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 40332
    • 4 Posts
    Hello,

    is anyone else using threaded comments with articles 1.6.2 (quip 2.3.1) with revo?

    When i activate threaded comments and create an comment for an other comment my html is completely broken. there will only the <ol> from the child-comment above the parent li. the parent li don't have an <ol> element anymore. something is very wrong.

    it looks like this:
    <ol class="comment-comment">
      <li>comment</li>
    </ol>
    <li>comment</li>
    <li>comment</li>
    

    instead of:
    <ol class="comment">
      <li>comment</li>
      <li>
        comment
        <ol class="comment-comment">
          <li>comment</li>
        </ol>
      </li>
    </ol>
    


    Can anyone help me with this?
      • 3749
      • 24,544 Posts
      Have you created any of your own Tpl chunks, or are you using the default ones?


      ------------------------------------------------------------------------------------------
      PLEASE, PLEASE specify the version of MODX you are using.
      MODX info for everyone: http://bobsguides.com/modx.html
        Did I help you? Buy me a beer
        Get my Book: MODX:The Official Guide
        MODX info for everyone: http://bobsguides.com/modx.html
        My MODX Extras
        Bob's Guides is now hosted at A2 MODX Hosting
        • 40332
        • 4 Posts
        I'm using the default ones.
        Had i to modify them to used threaded comments?
          • 3749
          • 24,544 Posts
          I'm not sure. I don't see any ol tags in the default templates, so I'm not sure where those are coming from.


          ------------------------------------------------------------------------------------------
          PLEASE, PLEASE specify the version of MODX you are using.
          MODX info for everyone: http://bobsguides.com/modx.html
            Did I help you? Buy me a beer
            Get my Book: MODX:The Official Guide
            MODX info for everyone: http://bobsguides.com/modx.html
            My MODX Extras
            Bob's Guides is now hosted at A2 MODX Hosting
            • 40332
            • 4 Posts
            The ol tags are created in these two files:
            core/components/quip/elements/chunks/quipcomments.chunk.tpl
            core/components/quip/elements/chunks/quipcomment.chunk.tpl

            The main ol tag is created here:
            core/components/quip/elements/chunks/quipcomments.chunk.tpl

            The ol tag for threaded comments will be created here:
            core/components/quip/elements/chunks/quipcomment.chunk.tpl

            Can't find the problem, because i'm new at modx. For me it's the code seems to be ok.
              • 3749
              • 24,544 Posts
              That's odd. All the ol tags are closed in those two files, as far as I can tell. If yours are not, maybe one of those files got truncated on upload. Here's what mine look like:

              quipcomments.chunk.tpl:

              <div class="quip">
                  <h3>[[%quip.comments]] ([[+total]])</h3>
              	
                  <div id="quip-topofcomments-[[+idprefix]]"></div>
              
                  [[+comments:notempty=`<ol class="quip-comment-list">
                  [[+comments]]
                  </ol>`]]
              
                  [[+pagination]]
              </div>


              quipcomment.chunk.tpl

              <li class="[[+cls]]" id="[[+idprefix]][[+id]]" [[+depth_margin:notempty=`style="padding-left: [[+depth_margin]]px"`]]>
              <div id="[[+idprefix]][[+id]]-div" class="quip-comment-body [[+alt]]">
                  <div class="quip-comment-right">
                      [[+gravatarUrl:notempty=`<img src="[[+gravatarUrl]]" class="quip-avatar" alt="" />`]]
                  </div>
              
                  <p class="quip-comment-meta">
                      <span class="quip-comment-author">[[+authorName]]:</span><br />
                      <span class="quip-comment-createdon"><a href="[[+url]]">[[+createdon]]</a>
                      [[+approved:if=`[[+approved]]`:is=`1`:then=``:else=`- <em>[[%quip.unapproved? &namespace=`quip` &topic=`default`]]</em>`]]
                      </span>
                  </p>
              
                  <div class="quip-comment-text">
                      <p>[[+body]]</p>
              
                      [[+replyUrl:notempty=`<p><span class="quip-reply-link"><a href="[[+replyUrl]]">[[%quip.reply? &namespace=`quip` &topic=`default`]]</a></span></p>`]]
                  </div>
              
                  <div class="quip-comment-options">
                      [[+report]]
                      [[+options]]
                  </div>
                  <div class="quip-break"></div>
              </div>
                  [[+children:notempty=`<ol class="quip-comment-list">[[+children]]</ol>`]]
              </li>
              




              Have you tried it in different browsers?


              ------------------------------------------------------------------------------------------
              PLEASE, PLEASE specify the version of MODX you are using.
              MODX info for everyone: http://bobsguides.com/modx.html [ed. note: BobRay last edited this post 11 years, 10 months ago.]
                Did I help you? Buy me a beer
                Get my Book: MODX:The Official Guide
                MODX info for everyone: http://bobsguides.com/modx.html
                My MODX Extras
                Bob's Guides is now hosted at A2 MODX Hosting