MODX :: Support/Comments for Easy 2 Gallery 1.4.0-RC1

0

Zombie Reply #1, 1 year, 11 months ago

Link to this post#1

This is an auto-generated topic for <a href="http://modxcms.com/extras/package/619">Easy 2 Gallery 1.4.0-RC1</a> by goldsky.

Brief Description:
See the HELP tab inside the module for the complete instruction.

Features of module:

1. Creation and editing of folders with unlimited nesting capabilities

2. Image or zip package uploading via POST method.

3. Synchronisation of gallery with files and folders uploaded via FTP.

4. Editing of image info

5. Comments moderation.

Snippet features:

1. Image viewing.

2. Comments viewing and adding

3. High customisation capabilities with templates and placeholders.

4. Breadcrumbs

5. Pagination

6. Integrated javascript display modes: colorbox, highslide, fancybox, floatbox,shadowbox,slimbox and lightwindow

7. Possible to display random image or single image

8. Possible to sort pictures and folders

9. Slideshows:

- Simple

- Galleriffic

- SmoothGallery

- GalleryView

- ContentFlow

Wiki:

http://wiki.modxcms.com/index.php/Easy2gallery

2,536

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison MODx is great, but knowing how to use it well makes it perfect!
Security, security, security!
Indonesia MODx Forum
MODx Revo's cheatsheets
MODx Evo's cheatsheets
IE 6 must die !
Easy 2 Gallery 1.4.x
spiefeed
Tutorial links
PING ME ON TWITTER @_goldsky

goldsky Reply #2, 1 year, 11 months ago

Link to this post#2

Bug:

<?php> // highlighting

private function _unzip($file, $path, $lng) {
   $e2g_encode = $this->e2gmod_cfg['e2g_encode']; // <-- please add this
   // more code
}

For Smoothgallery user: slideshows/smoothgallery/smoothgallery.php, line: 348.
Supposed to be like this

<?php> // highlighting
$_ssfile['thumbsrc'][$k][] = $this->_get_thumb($gdir, $path.$fetch['filename'], $w, $h, $thq);
$_ssfile['resizedimg'][$k][] = $this->_get_thumb($gdir, $path.$fetch['filename'], $ss_w, $ss_h, $thq);

15,111

How MODx Evo Works

Log in to an Evo Manager username guest, password guestuser.

sottwell Reply #3, 1 year, 11 months ago

Link to this post#3

On downloading, the filename e2g 1.4.0 rc1 r175.zip is truncated to e2g; apparently something in there doesn't like the spaces in the filename.

36

geertdeg Reply #4, 1 year, 11 months ago

Link to this post#4

How could Easy 2 Gallery be used in a multi-lingual site? Should it be possible to have translations for the "title" en "description" fields for the uploaded images? I want 1-album-on-many-languages or 1-album-on-many-entries (which is already possible).

2,536

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison MODx is great, but knowing how to use it well makes it perfect!
Security, security, security!
Indonesia MODx Forum
MODx Revo's cheatsheets
MODx Evo's cheatsheets
IE 6 must die !
Easy 2 Gallery 1.4.x
spiefeed
Tutorial links
PING ME ON TWITTER @_goldsky

goldsky Reply #5, 1 year, 11 months ago

Link to this post#5

Quote from: sottwell at Jun 08, 2010, 07:52 AM

On downloading, the filename e2g 1.4.0 rc1 r175.zip is truncated to e2g; apparently something in there doesn't like the spaces in the filename.

Package is updated: e2g-1.4.0-rc1-r180.zip
Thx for reporting, susan.

Quote from: geertdeg at Jun 08, 2010, 04:35 PM

How could Easy 2 Gallery be used in a multi-lingual site? Should it be possible to have translations for the "title" en "description" fields for the uploaded images? I want 1-album-on-many-languages or 1-album-on-many-entries (which is already possible).

Good question.
I'll provide a string callback, so anyone can create functions to all output string. This should the best option to be able to hook up to other language snippets (like YAMS or anything else).

2,536

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison MODx is great, but knowing how to use it well makes it perfect!
Security, security, security!
Indonesia MODx Forum
MODx Revo's cheatsheets
MODx Evo's cheatsheets
IE 6 must die !
Easy 2 Gallery 1.4.x
spiefeed
Tutorial links
PING ME ON TWITTER @_goldsky

goldsky Reply #6, 1 year, 11 months ago

Link to this post#6

@fixedmachine, Looks like the Zaż word is very special, since I can not zip it back with my WinRar.
~~What character is it?~~ Nevermind. http://en.wikipedia.org/wiki/%C5%BB

You know what? Even PHP (encoding=='none') 271 : Could not delete files.

82

fixedmachine Reply #7, 1 year, 11 months ago

Link to this post#7

Quote from: goldsky at Jun 08, 2010, 10:53 PM

@fixedmachine, Looks like the Zaż word is very special, since I can not zip it back with my WinRar.

You know what? Even PHP (encoding=='none') 271 : Could not delete files.

That's really weird. I can pack it with my WinRar and any other packers without problems. I don't know why should that letter generate any special problems. In the version I send you there was only problems with some files with "ż" in the file name inside zip. With the same file uploaded normally (not in zip) everything was fine. But even if there was a file with "ż" letter in its name - when "ż" was on further position everything was fine. Weird? I can bet, that the problem lies inside ZipArchive class.

But now after installing the newest version of e2g from svn (r190) I see that we have additional problems

Goldsky, you can't rely on mb_detect_encoding. Sometimes it could return false, and we end up with error:

Warning: Argument 2 passed to UTF8::convert_to() must be an string, boolean given, called in /home/domains/domain.net/public_html/assets/modules/easy2/includes/classes/e2g.public.class.php on line 58 and defined in /home/domains/domain.net/public_html/assets/modules/easy2/includes/UTF8-2.1.0/UTF8.php on line 1546 in /home/domains/domain.net/public_html/assets/modules/easy2/includes/UTF8-2.1.0/ReflectionTypehint.php  on line 70

So in e2g.public.class.php we can't have:

<?php> // highlighting
$converted_text = UTF8::convert_to($text,mb_detect_encoding($text));

Anyway. We've got a mess with encoding. There is too much 'e2g_decode' and 'e2g_encode' where we don't need it.

We need to rebuild that functionality.

I think that the general procedure should look like this:
1. UPLOAD - we detect encoding of uploaded file name and if it's different than UTF-8 -> convert it to UTF-8.
2. SAVE - save file with UTF-8 encoded file name
3. DISPLAY - because we know that our file name could contain non-ASCII characters we must URI encode all paths to them (http://www.w3.org/International/O-URL-code.html )

This is the base. Of course we need to consider synchronization and downloading(zip).

Did I miss something?

I'll try to fix that things.

15,111

How MODx Evo Works

Log in to an Evo Manager username guest, password guestuser.

sottwell Reply #8, 1 year, 11 months ago

Link to this post#8

Question... in the comments manager, there is a button on the IP address to "ignore". What does this do?

82

fixedmachine Reply #9, 1 year, 11 months ago

Link to this post#9

Quote from: sottwell at Jun 13, 2010, 09:08 AM

Question... in the comments manager, there is a button on the IP address to "ignore". What does this do?

It's for banning chosen IP addresses. Of course it's not perfect solution, but you can sometimes block some of the annoying posters/spammers.

15,111

How MODx Evo Works

Log in to an Evo Manager username guest, password guestuser.

sottwell Reply #10, 1 year, 11 months ago

Link to this post#10

That's what I thought. It would be useful to check for that when getting the comment count, though. I'm also thinking of having it allow the first submission from the IP instead of (or optionally) ignoring everything from that address. I'll have to do that in any case in my voting modification to the commenting feature.